Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds --output to flatten #5947

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: adds --output to flatten #5947

wants to merge 4 commits into from
+73 −41

Conversation

s-di-cola
Copy link

  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.

Implements --output parameter for flatten task as requested in #3430. This allows users to specify an output file path for the flattened contract, improving usability especially on Windows systems where shell redirection may not work consistently.

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:18pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 31c0a94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fvictorio
Copy link
Member

This looks good, but I'll let someone from the Hardhat team actually review it in depth and approve it. This also needs a changeset, of course.

@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Nov 22, 2024
@kanej kanej requested a review from galargh November 22, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvictorio fvictorio fvictorio left review comments

@galargh galargh Awaiting requested review from galargh

At least 1 approving review is required to merge this pull request.

Assignees

@kanej kanej

Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-di-cola @fvictorio @kanej